Skip to content

Bugfix #218 - #230

Merged
maiyishan merged 3 commits into
vnbdevfrom
bugfix_218
Sep 10, 2026
Merged

Bugfix #218#230
maiyishan merged 3 commits into
vnbdevfrom
bugfix_218

Conversation

@maiyishan

Copy link
Copy Markdown
Collaborator
  • Bugfix for issue 218 (ability to color slopegraphs and delta dots). Changes paired color check for bootstrap distribution to be the same as unpaired (since unpaired was working).
  • Additionally fixes install (originally there were issues with install due to non-UTF8 encoded characters in README.md) and path issues in pyproject.toml

Bug fix:
Changes bootstraps_color_by_group  check in misc_tools to work the same way for both paired data and unpaired data (since unpaired data was working), with the exception of delta-delta and Sankey
pytest CI failing at one of the hedges' g paired plots due to color of the bootstrap distribution; reworking of bootstrap distribution color check in an attempt to fix
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@maiyishan
maiyishan requested review from Jacobluke- and sangyu August 20, 2026 07:25
- Support `custom_palette` dicts together with `color_col`, which still raised
  "The `custom_palette` dictionary is not supported when `color_col` is not
  None." The palette is now keyed by the `color_col` categories, as the
  `plot()` docstring already describes, with an explicit error listing any
  category left without a colour.

- Collapse the paired branch of `get_color_palette` to the single condition it
  encodes. The nested branches recomputed `color_groups` and re-raised a
  KeyError that the block directly above already handles; rendered output is
  unchanged.

- Add `nbs/tests/test_color_palette.py`. Paired + `color_col` +
  `custom_palette` had no coverage at all, which is how #207 broke it: the two
  existing tests that pass both arguments use an unpaired object, so they never
  reach this branch.

- Read README.md as UTF-8 in setup.py rather than replacing its curly quotes.
  The install failure came from the locale-dependent `open()`, so any future
  non-ASCII character would have brought it back.
@maiyishan
maiyishan merged commit 6667a1b into vnbdev Sep 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants